Skip to content

Add avalanche coordinate system to particle properties (ana3AIMEC) - #792

Merged
fso42 merged 1 commit into
masterfrom
TransformAimecParticlesVersion2
Dec 7, 2022
Merged

Add avalanche coordinate system to particle properties (ana3AIMEC)#792
fso42 merged 1 commit into
masterfrom
TransformAimecParticlesVersion2

Conversation

@oscar-dick

Copy link
Copy Markdown
Contributor

Projecting particles properties in the avalanche coordinate system

@codecov

codecov Bot commented Dec 5, 2022

Copy link
Copy Markdown

Codecov Report

Base: 75.32% // Head: 75.37% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (24856f8) compared to base (06135d1).
Patch coverage: 88.88% of modified lines in pull request are covered.

❗ Current head 24856f8 differs from pull request most recent head 18c294c. Consider uploading reports for the commit 18c294c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #792      +/-   ##
==========================================
+ Coverage   75.32%   75.37%   +0.04%     
==========================================
  Files          59       59              
  Lines       12555    12583      +28     
==========================================
+ Hits         9457     9484      +27     
- Misses       3098     3099       +1     
Impacted Files Coverage Δ
avaframe/ana3AIMEC/aimecTools.py 81.74% <60.00%> (+0.03%) ⬆️
avaframe/out3Plot/outAIMEC.py 84.72% <80.00%> (-0.15%) ⬇️
avaframe/ana3AIMEC/ana3AIMEC.py 86.77% <100.00%> (+1.59%) ⬆️
avaframe/ana5Utils/distanceTimeAnalysis.py 83.58% <100.00%> (+0.75%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fso42 fso42 added the enhancement New feature or request label Dec 5, 2022
Comment thread avaframe/ana3AIMEC/ana3AIMEC.py
Comment thread avaframe/ana3AIMEC/ana3AIMEC.py
Comment thread avaframe/ana3AIMEC/ana3AIMEC.py
@fso42

fso42 commented Dec 6, 2022

Copy link
Copy Markdown
Contributor

As discussed, please add a test for the new function

@fso42 fso42 added this to the Version 1.4 milestone Dec 6, 2022
 - adding Aimec changes
 - Adding a test to test_ana3Aimec
@fso42
fso42 force-pushed the TransformAimecParticlesVersion2 branch from 24856f8 to 18c294c Compare December 7, 2022 08:46
@fso42 fso42 changed the title adding Aimec changes Add avalanche coordinate system to particle coordinates (ana3AIMEC) Dec 7, 2022
@fso42 fso42 changed the title Add avalanche coordinate system to particle coordinates (ana3AIMEC) Add avalanche coordinate system to particle properties (ana3AIMEC) Dec 7, 2022
@qlty-cloud-legacy

Copy link
Copy Markdown

Code Climate has analyzed commit 18c294c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 73.3%.

View more on Code Climate.

@fso42
fso42 merged commit ca9ebde into master Dec 7, 2022
@fso42
fso42 deleted the TransformAimecParticlesVersion2 branch December 7, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants