Skip to content

Fix saving plots and report generation [out3Plots][out1Peak] - #803

Merged
fso42 merged 1 commit into
masterfrom
savePlotReport
Jan 9, 2023
Merged

Fix saving plots and report generation [out3Plots][out1Peak]#803
fso42 merged 1 commit into
masterfrom
savePlotReport

Conversation

@awirb

@awirb awirb commented Jan 5, 2023

Copy link
Copy Markdown
Contributor
  • use plotAndOrSave function to save figures also in older files
  • New option to turn off report generation completely (see main ini file)

@awirb
awirb requested a review from fso42 January 5, 2023 11:34
@fso42 fso42 linked an issue Jan 5, 2023 that may be closed by this pull request
@fso42 fso42 changed the title fix saving plots and report generation ix saving plots and report generation Jan 5, 2023
@fso42 fso42 changed the title ix saving plots and report generation Fix saving plots and report generation [out3Plots] Jan 5, 2023
@fso42 fso42 changed the title Fix saving plots and report generation [out3Plots] Fix saving plots and report generation [out3Plots][out1Peak] Jan 5, 2023
@fso42 fso42 added the confirmed Something isn't working label Jan 5, 2023
@fso42 fso42 added this to the Version 1.4 milestone Jan 5, 2023
@codecov

codecov Bot commented Jan 9, 2023

Copy link
Copy Markdown

Codecov Report

Base: 75.17% // Head: 75.29% // Increases project coverage by +0.11% 🎉

Coverage data is based on head (f3be32a) compared to base (df3d630).
Patch coverage: 26.31% of modified lines in pull request are covered.

❗ Current head f3be32a differs from pull request most recent head a89655f. Consider uploading reports for the commit a89655f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #803      +/-   ##
==========================================
+ Coverage   75.17%   75.29%   +0.11%     
==========================================
  Files          59       59              
  Lines       12929    12901      -28     
==========================================
- Hits         9720     9714       -6     
+ Misses       3209     3187      -22     
Impacted Files Coverage Δ
avaframe/out3Plot/in1DataPlots.py 0.00% <0.00%> (ø)
avaframe/out3Plot/outTopo.py 0.00% <0.00%> (ø)
avaframe/out3Plot/statsPlots.py 22.26% <20.00%> (+0.69%) ⬆️
avaframe/com1DFA/com1DFA.py 91.17% <100.00%> (+<0.01%) ⬆️
avaframe/out1Peak/outPlotAllPeak.py 99.07% <100.00%> (+0.84%) ⬆️
avaframe/out3Plot/outQuickPlot.py 93.10% <100.00%> (+0.24%) ⬆️
avaframe/out3Plot/plotUtils.py 94.49% <0.00%> (ø)
avaframe/out3Plot/outDistanceTimeAnalysis.py 82.94% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@qlty-cloud-legacy

Copy link
Copy Markdown

Code Climate has analyzed commit a89655f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 26.3% (50% is the threshold).

This pull request will bring the total coverage in the repository to 73.3% (0.0% change).

View more on Code Climate.

@fso42
fso42 merged commit f1cd915 into master Jan 9, 2023
@fso42
fso42 deleted the savePlotReport branch January 9, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

confirmed Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error on "savePlot" = False (in avaframeCFG.ini)

2 participants