Skip to content

Remove unused location option in addColorBar [out3Plot] - #804

Merged
fso42 merged 1 commit into
masterfrom
fixColorbarLocation
Jan 9, 2023
Merged

Remove unused location option in addColorBar [out3Plot]#804
fso42 merged 1 commit into
masterfrom
fixColorbarLocation

Conversation

@fso42

@fso42 fso42 commented Jan 5, 2023

Copy link
Copy Markdown
Contributor

The relevant change is in plotUtils -> addColorBar; rest is black formatting

@fso42 fso42 added confirmed Something isn't working enhancement New feature or request labels Jan 5, 2023
@fso42 fso42 added this to the Version 1.4 milestone Jan 5, 2023
@fso42
fso42 requested a review from awirb January 5, 2023 20:41
@fso42 fso42 self-assigned this Jan 5, 2023
@qlty-cloud-legacy

Copy link
Copy Markdown

Code Climate has analyzed commit 6cebe95 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 80.8% (50% is the threshold).

This pull request will bring the total coverage in the repository to 73.2%.

View more on Code Climate.

@codecov

codecov Bot commented Jan 5, 2023

Copy link
Copy Markdown

Codecov Report

Base: 75.17% // Head: 75.17% // No change to project coverage 👍

Coverage data is based on head (6cebe95) compared to base (93c5113).
Patch coverage: 80.80% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #804   +/-   ##
=======================================
  Coverage   75.17%   75.17%           
=======================================
  Files          59       59           
  Lines       12929    12929           
=======================================
  Hits         9720     9720           
  Misses       3209     3209           
Impacted Files Coverage Δ
avaframe/out3Plot/plotUtils.py 94.49% <ø> (ø)
avaframe/out3Plot/outDistanceTimeAnalysis.py 82.94% <80.80%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fso42
fso42 merged commit 401945d into master Jan 9, 2023
@fso42
fso42 deleted the fixColorbarLocation branch January 9, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

confirmed Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant