Skip to content

fix bug simName modelType, add sphKernelRadius setting option [com1DFA] - #805

Merged
fso42 merged 1 commit into
masterfrom
sphKernelCellSize
Jan 10, 2023
Merged

fix bug simName modelType, add sphKernelRadius setting option [com1DFA]#805
fso42 merged 1 commit into
masterfrom
sphKernelCellSize

Conversation

@awirb

@awirb awirb commented Jan 10, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@awirb
awirb requested a review from fso42 January 10, 2023 09:37
@fso42 fso42 added confirmed Something isn't working enhancement New feature or request labels Jan 10, 2023
@fso42 fso42 added this to the Version 1.4 milestone Jan 10, 2023
@fso42 fso42 changed the title fix bug simName modelType, add sphKernelRadius setting option fix bug simName modelType, add sphKernelRadius setting option [com1DFA] Jan 10, 2023
@codecov

codecov Bot commented Jan 10, 2023

Copy link
Copy Markdown

Codecov Report

Base: 75.19% // Head: 75.19% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (8e5d731) compared to base (7d2f3d9).
Patch coverage: 76.19% of modified lines in pull request are covered.

❗ Current head 8e5d731 differs from pull request most recent head e92d2e4. Consider uploading reports for the commit e92d2e4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #805      +/-   ##
==========================================
- Coverage   75.19%   75.19%   -0.01%     
==========================================
  Files          59       59              
  Lines       12937    12955      +18     
==========================================
+ Hits         9728     9741      +13     
- Misses       3209     3214       +5     
Impacted Files Coverage Δ
avaframe/com1DFA/checkCfg.py 63.15% <71.42%> (+4.82%) ⬆️
avaframe/in3Utils/fileHandlerUtils.py 85.28% <72.72%> (-0.57%) ⬇️
avaframe/com1DFA/com1DFA.py 91.26% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fso42
fso42 force-pushed the sphKernelCellSize branch from 8e5d731 to e92d2e4 Compare January 10, 2023 12:48
@qlty-cloud-legacy

Copy link
Copy Markdown

Code Climate has analyzed commit e92d2e4 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 76.1% (50% is the threshold).

This pull request will bring the total coverage in the repository to 73.2% (0.0% change).

View more on Code Climate.

@fso42
fso42 merged commit 8859b38 into master Jan 10, 2023
@fso42
fso42 deleted the sphKernelCellSize branch January 10, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

confirmed Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants