Skip to content

[AR-5926] Move UI related code to Wallet UI source code.#170

Merged
karthik-durai merged 17 commits intodevfrom
karthik/AR-5926-move-show-hide-logic-of-wallet-ui-to-its-src
May 10, 2023
Merged

[AR-5926] Move UI related code to Wallet UI source code.#170
karthik-durai merged 17 commits intodevfrom
karthik/AR-5926-move-show-hide-logic-of-wallet-ui-to-its-src

Conversation

@karthik-durai
Copy link
Contributor

@karthik-durai karthik-durai commented Apr 4, 2023

PR

Describe your changes

  1. Removed code that created Wallet Bubble/Button.
  2. Removed Code that Creates Wallet Iframe structure instead just creating iframe.
  3. Set default size of iframe as zero and position to right bottom.
  4. Removed code that Show/Hide wallet in Auth SDK.
  5. Add two methods to manage Wallet size and position (setIframeStyle and getWalletPosition).

Issue ticket number and link

Checklist before requesting a review

  • You have performed a self-review of your own code
  • You are using approved terminology
  • Your changes have been tested locally
  • Your code builds clean without any errors or warnings

@netlify
Copy link

netlify bot commented Apr 4, 2023

Deploy Preview for dev-authsdk-ref-guide ready!

Name Link
🔨 Latest commit 1d4a79b
🔍 Latest deploy log https://app.netlify.com/sites/dev-authsdk-ref-guide/deploys/645a1f7cc04d9900082a14d6
😎 Deploy Preview https://deploy-preview-170--dev-authsdk-ref-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 4, 2023

Deploy Preview for authsdk-ref-guide ready!

Name Link
🔨 Latest commit 1d4a79b
🔍 Latest deploy log https://app.netlify.com/sites/authsdk-ref-guide/deploys/645a1f7c87e8b700089062ab
😎 Deploy Preview https://deploy-preview-170--authsdk-ref-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@karthik-durai karthik-durai requested a review from makylfang April 4, 2023 06:23
@karthik-durai karthik-durai merged commit e01a68a into dev May 10, 2023
@karthik-durai karthik-durai deleted the karthik/AR-5926-move-show-hide-logic-of-wallet-ui-to-its-src branch May 10, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants