Behaviour change - match Spring for overriding and fallback values #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rename ConfigurationFallbacks to ConfigurationFallback - Change List<ConfigurationFallbacks> fallbacks to single ConfigurationFallback fallback - Make DefaultFallback final - Rename method Configuration.Builder.withFallbacks() to fallback()
- add overrideValue() method - Invoke overrideValue() on initial load and builder load
This allows us to override the source along with the value. A downside is that we need to expose more methods on the Entry interface that were otherwise internal to CoreEntry.
Rather than nullable, and thus allow the source to also be provided by the fallback method.
rob-bygrave
changed the title
SentryMan
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the behaviour to match Spring such that properties loaded have their values overridden by System properties (if exist) and then by Environment variables (if exist).
Similarly, the fallback values used when a no entry was loaded via a properties source will also first lookup System properties and then Environment variables [which matches the existing behaviour of avaje-config, no change to the fallback value case].