Skip to content

Throw an exception if trying to send a request on a closed client #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 26, 2025
Merged

Throw an exception if trying to send a request on a closed client #656

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da6414e
closed
SentryMan Oct 26, 2025
a014a11
Remove extra whitespace
rbygrave Oct 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions http-client/src/main/java/io/avaje/http/client/DHttpClientContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ final class DHttpClientContext implements HttpClient, SpiHttpClient {
private final LongAccumulator metricResMaxMicros = new LongAccumulator(Math::max, 0);
private final Function<HttpException, RuntimeException> errorHandler;

private boolean closed;

DHttpClientContext(
java.net.http.HttpClient httpClient,
String baseUrl,
Expand Down Expand Up @@ -86,6 +88,9 @@ public <T> T create(Class<T> clientInterface, ClassLoader classLoader) {

@Override
public HttpClientRequest request() {
if (closed) {
throw new IllegalStateException("HttpClient is closed");
}
return retryHandler == null
? new DHttpClientRequest(this, requestTimeout)
: new DHttpClientRequestWithRetry(this, requestTimeout, retryHandler);
Expand Down Expand Up @@ -389,6 +394,7 @@ String maxResponseBody(String body) {

@Override
public void close() {
this.closed = true;
if (Integer.getInteger("java.specification.version") >= 21) {
try {
MethodHandles.lookup()
Expand Down