-
Notifications
You must be signed in to change notification settings - Fork 16
Adds a default validation exception handler #670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@mechite how's this? |
mechite
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SentryMan hard to review on a phone 🤣 I like it
|
@SentryMan I'm reviewing here now on a computer.
We can do something like: @SentryMan I see JSON Schema for HTTP Problems which is a specification for how the responses are meant to look. While the following doesn't exclude the "avaje" name from the response, it does make it more abstract: If we upload this schema to |
idk what to make of this statement |
this guy
I mean that we basically can just point to a class file in Avaje, instead of a web URL Ideally to me, this JSON schema I said that the RFC contains, could have been uploaded to e.g. ietf.org,
This suggestion was to say that we upload the official JSON schema, which is probably more useful |
|
d55a7a6 - OK, but we better verify that this is indeed valid for the |
Would this really be worth it over adding json-core or even full jsonb - since they have streaming writers? |
nahhh it's probably fine |
Pull request was converted to draft
|
🤣 he says it's fine, then optimizes anyway |
Removed unused getter methods from ValidationResponse.
Resolves #669 by adding a default handler via the inject plugin