Skip to content

Add Compile Warning for Http Valid when used outside a Controller #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 22, 2025
+13 −7
Merged

Add Compile Warning for Http Valid when used outside a Controller #672

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4fad803
add compile warning for http valid
SentryMan Nov 21, 2025
b2add98
Merge branch 'master' into valid-warning
rbygrave Nov 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions http-generator-core/src/main/java/io/avaje/http/generator/core/BaseProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
import javax.annotation.processing.SupportedOptions;
import javax.lang.model.SourceVersion;
import javax.lang.model.element.Element;
import javax.lang.model.element.ExecutableElement;
import javax.lang.model.element.Modifier;
import javax.lang.model.element.TypeElement;
import javax.lang.model.util.ElementFilter;
Expand Down Expand Up @@ -54,11 +53,12 @@ public SourceVersion getSupportedSourceVersion() {
@Override
public Set<String> getSupportedAnnotationTypes() {
return Set.of(
PathPrism.PRISM_TYPE,
ControllerPrism.PRISM_TYPE,
OpenAPIDefinitionPrism.PRISM_TYPE,
MappedParamPrism.PRISM_TYPE,
MapImportPrism.PRISM_TYPE);
PathPrism.PRISM_TYPE,
ControllerPrism.PRISM_TYPE,
OpenAPIDefinitionPrism.PRISM_TYPE,
MappedParamPrism.PRISM_TYPE,
MapImportPrism.PRISM_TYPE,
HttpValidPrism.PRISM_TYPE);
}

@Override
Expand Down Expand Up @@ -91,7 +91,7 @@ public boolean process(Set<? extends TypeElement> annotations, RoundEnvironment
if (round.errorRaised()) {
return false;
}

getElements(round, HttpValidPrism.PRISM_TYPE).forEach(this::warnValid);
for (final var type : ElementFilter.typesIn(getElements(round, MappedParamPrism.PRISM_TYPE))) {
var prism = MappedParamPrism.getInstanceOn(type);
registerParamMapping(type, prism.factoryMethod());
Expand Down Expand Up @@ -148,6 +148,12 @@ public boolean process(Set<? extends TypeElement> annotations, RoundEnvironment
return false;
}

private void warnValid(Element e) {
if (!ControllerPrism.isPresent(e) && !ControllerPrism.isPresent(e.getEnclosingElement())) {
logWarn(e, "%s should only be used in Controller Classes", HttpValidPrism.PRISM_TYPE);
}
}

private Set<? extends Element> getElements(RoundEnvironment round, String name) {
return Optional.ofNullable(typeElement(name))
.map(round::getElementsAnnotatedWith)
Expand Down