Edit FlupkeSystemLogger method to lock
#329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `null` check that just output the message was previously not using the lock, though I don't think it's a big issue and I'm not sure why there is a lock in the first place. I inherited that from Flupke, so it's better safe than sorry, though I'm pretty sure System.Logger makes those guarantees, but so does even `System.out`/`System.err`, so it's better to assume that ptrd had his reasons for locking here Signed-off-by: Mahied Maruf <contact@mechite.com>
SentryMan
approved these changes
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
nullcheck that just output the message was previously not usingthe lock, though I don't think it's a big issue and I'm not sure why
there is a lock in the first place.
I inherited that from Flupke, so it's better safe than sorry, though
I'm pretty sure System.Logger makes those guarantees, but so does even
System.out/System.err, so it's better to assume that ptrd had hisreasons for locking here
Signed-off-by: Mahied Maruf contact@mechite.com