Skip to content

Conversation

@SentryMan
Copy link
Collaborator

@SentryMan SentryMan commented Nov 22, 2025

  • Will log a compiler warning if processed class has no constraints

part of #333

@SentryMan SentryMan added this to the 2.15 milestone Nov 22, 2025
@SentryMan SentryMan self-assigned this Nov 22, 2025
@SentryMan SentryMan added the enhancement New feature or request label Nov 22, 2025
@SentryMan SentryMan requested a review from rbygrave November 22, 2025 20:58
@SentryMan SentryMan enabled auto-merge (squash) November 22, 2025 20:58
@rbygrave
Copy link
Contributor

#333 is not clear yet as to the motivations yet. It isn't clear to me why we are doing this and what the implications are.

@SentryMan
Copy link
Collaborator Author

warning when you have no constraints is common sense

@rbygrave
Copy link
Contributor

rbygrave commented Nov 24, 2025

will only cascade if valid annotation is present

This to me is a fairly significant behaviour change / bug fix. As such it really needs to be in it's own PR with it's own title rather than part of "Warn on No Constraints".

I think we need to split that out into a separate PR.


Edit: Note that it wasn't actually a behaviour change, but instead just generated extra code that was never used. I interpreted that part incorrectly.

@SentryMan
Copy link
Collaborator Author

SentryMan commented Nov 24, 2025

This to me is a fairly significant behaviour change / bug fix.

I fail to understand, if a field/TYPE_USE field is not annotated with @Valid there is no circumstance where it should have an adapter generated. The adapter would just be unused because there is no code path where it is called

I think we need to split that out into a separate PR.

#340

@SentryMan SentryMan merged commit ad52bce into main Nov 24, 2025
8 checks passed
@SentryMan SentryMan deleted the validate-empty branch November 24, 2025 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants