Missing test fixture

[vadimdemedes]

Occurs in latest master.

[sotojuan]

Actually that's just output from the rejects on error and streams output test in fork.js, which tests the error output when given a nonexistent file (broken.js is not supposed to exist!). While we test for the correct message in the err object, the fork function logs the ENOENT error to the console. It's expected and not a "real" error! That said if you know of a way to suppress that output, I'd be happy to implement it. Maybe with hook-std?

[sindresorhus]

the fork function logs the ENOENT error to the console.

It definitely shouldn't do that. Might be an exception leak somewhere that aren't caught in any promises.

[sotojuan]

Makes sense. I'll look into it.

[jamestalmage]

This is a byproduct of #308. We are intentionally delaying the installation of our own uncaughtException handler so that the correct location for the SyntaxError will be printed. That has the unfortunate side effect of meaning we lose control of when those errors print.

I think @sotojuan's first instinct was correct. Use hook-std to mask the error for that particular test.

[ariporad]

I'll look into this.

[jamestalmage]

Please read #308. There is no "fixing" this beyond suppressing stderr/stdout for this one test fixture using hook-std. Our options are:

1. catch and display the error yourself (i.e. maintain control)
2. See the correct source/line number for syntax errors.

2 is more important. We are choosing the lesser of two evils

[ariporad]

@jamestalmage: I know.

After some debugging, I found out that somehow the child process bypasses the parents stderr, as I've tried hook-std, several other npm packages, and several implementations that I've done myself, and none have worked.

[jamestalmage]

Extend fork.js to allow us to pass custom options to child_process.fork.
Then use stdio option and provide a stream we can inspect. [null, stdout, stderr]

[ariporad]

@jamestalmage: Tried that. Didn't work. Tried just manually passing in 'ignore'. Didn't work. My theory is that fs overrides the options passed to fork, in an evil fashion.