Skip to content

Removed period at end of only()/exclusive output in mini and verbose reporters #1189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
novemberborn merged 1 commit into from
Jan 16, 2017
Merged

Removed period at end of only()/exclusive output in mini and verbose reporters #1189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/reporters/mini.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ MiniReporter.prototype.finish = function (runStatus) {
}

if (runStatus.hasExclusive === true && runStatus.remainingCount > 0) {
status += '\n\n ' + colors.information('The .only() modifier is used in some tests.', runStatus.remainingCount, plur('test', runStatus.remainingCount), plur('was', 'were', runStatus.remainingCount), 'not run.');
status += '\n\n ' + colors.information('The .only() modifier is used in some tests.', runStatus.remainingCount, plur('test', runStatus.remainingCount), plur('was', 'were', runStatus.remainingCount), 'not run');
}

return status + '\n\n';
Expand Down
2 changes: 1 addition & 1 deletion lib/reporters/verbose.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ VerboseReporter.prototype.finish = function (runStatus) {
}

if (runStatus.hasExclusive === true && runStatus.remainingCount > 0) {
output += '\n\n\n ' + colors.information('The .only() modifier is used in some tests.', runStatus.remainingCount, plur('test', runStatus.remainingCount), plur('was', 'were', runStatus.remainingCount), 'not run.');
output += '\n\n\n ' + colors.information('The .only() modifier is used in some tests.', runStatus.remainingCount, plur('test', runStatus.remainingCount), plur('was', 'were', runStatus.remainingCount), 'not run');
}

return output + '\n';
Expand Down
4 changes: 2 additions & 2 deletions test/reporters/mini.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,7 +615,7 @@ test('results when hasExclusive is enabled, but there is one remaining tests', f
var expectedOutput = [
'',
'',
' ' + colors.information('The .only() modifier is used in some tests. 1 test was not run.'),
' ' + colors.information('The .only() modifier is used in some tests. 1 test was not run'),
'\n'
].join('\n');
t.is(actualOutput, expectedOutput);
Expand All @@ -636,7 +636,7 @@ test('results when hasExclusive is enabled, but there are multiple remaining tes
var expectedOutput = [
'',
'',
' ' + colors.information('The .only() modifier is used in some tests. 2 tests were not run.'),
' ' + colors.information('The .only() modifier is used in some tests. 2 tests were not run'),
'\n'
].join('\n');
t.is(actualOutput, expectedOutput);
Expand Down
4 changes: 2 additions & 2 deletions test/reporters/verbose.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,7 +499,7 @@ test('results when hasExclusive is enabled, but there is one remaining tests', f
' ' + chalk.green('1 test passed') + time,
'',
'',
' ' + colors.information('The .only() modifier is used in some tests. 1 test was not run.'),
' ' + colors.information('The .only() modifier is used in some tests. 1 test was not run'),
''
].join('\n');

Expand All @@ -522,7 +522,7 @@ test('results when hasExclusive is enabled, but there are multiple remaining tes
' ' + chalk.green('1 test passed') + time,
'',
'',
' ' + colors.information('The .only() modifier is used in some tests. 2 tests were not run.'),
' ' + colors.information('The .only() modifier is used in some tests. 2 tests were not run'),
''
].join('\n');

Expand Down