Speed up flow check #1241
Merged
Speed up flow check #1241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`flow check` is easily taking 30 seconds on my development machine, presumably it's checking too many files. Move the .flowconfig into the flow-types test directory and only include the index.js.flow file to improve check speed.
Member
|
Let's merge this now. The slowness is painful. We can improve it further if @leebyron has any additional suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flow checkis easily taking 30 seconds on my development machine, presumably it's checking too many files. Move the.flowconfiginto the flow-types test directory and only include theindex.js.flowfile to improve check speed.I've verified it still catches type errors by reverting the
notThrowsfix from #1230.@leebyron does my analysis make sense? Given how the
ignoreexpressions work I don't think there's any other way of restrictingflow checkto just the three.js.flowfiles we currently have.