Skip to content

Code excerpt fixes #1271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sindresorhus merged 4 commits into from
Feb 18, 2017
Merged

Code excerpt fixes #1271

sindresorhus merged 4 commits into from
Feb 18, 2017

Conversation

@novemberborn
Copy link
Member

@novemberborn novemberborn commented Feb 16, 2017 •
edited by sindresorhus
Loading

Fixes #1270
Fixes #1268

@vadimdemedes
Copy link
Contributor

vadimdemedes commented Feb 16, 2017

This is nice! I like the new isWithinProject and isDependency props.

Builds are failing though. Otherwise, 👍

@novemberborn novemberborn mentioned this pull request Feb 17, 2017
Closed
@novemberborn
Resolve absolute source file path when serializing errors
30ce546 
Fixes #1270.
@novemberborn
Bail excerpting code if file cannot be read
6e3f871
@novemberborn
temp-write@^3.1.0
d9be329
@novemberborn
Restrict code excerpts to tests/helpers/sources
6497ca9 
Don't show code excerpts for dependencies or code outside the project
directory. Determine where the source lives when serializing the error.
Then, when excerpting the code, bail if it lives outside the project
or is a dependency.
@novemberborn
Copy link
Member Author

novemberborn commented Feb 17, 2017

Builds are failing though

Fixed now. On my local machine tap was including source-map-support, but that didn't seem to be happening on CI. Perhaps a caching issue, but it's better to include it explicitly anyway.

@sindresorhus sindresorhus merged commit f3b60f4 into master Feb 18, 2017
@sindresorhus sindresorhus deleted the code-excerpt-fixes branch February 18, 2017 08:44
@sindresorhus
Copy link
Member

sindresorhus commented Feb 18, 2017

Excellent :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@vadimdemedes vadimdemedes vadimdemedes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@novemberborn @vadimdemedes @sindresorhus