Fix coverage #264
Closed
Fix coverage #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamestalmage
force-pushed
the
fix-coverage
branch
from
0934b03 to
6891d8b
Compare
Due to NYC defaults, we were missing coverage on lib/test.js I also added `npm run coverage` as a build target, which is for use on developer machines. It launches a browser window with coverage from the last run. We no longer need NYC as a dev dependency. `tap` handles it for us. `maintaining.md` updated to reflect all these changes.
jamestalmage
force-pushed
the
fix-coverage
branch
from
6891d8b to
172f6d8
Compare
jamestalmage
added a commit
that referenced
this pull request
Nov 24, 2015
Due to NYC defaults, we were missing coverage on lib/test.js I also added `npm run coverage` as a build target, which is for use on developer machines. It launches a browser window with coverage from the last run. We no longer need NYC as a dev dependency. `tap` handles it for us. `maintaining.md` updated to reflect all these changes.
Member
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to NYC defaults, we were missing coverage on lib/test.js
I also added
npm run coverageas a build target, which is for useon developer machines. It launches a browser window with coverage
from the last run.
We no longer need NYC
or coverallsas dev dependencies.taphandlesit all for us magically.
maintaining.mdupdated to reflect all these changes.Also - I dropped coverage from the Windows tests. We don't need to make AppVeyor any slower.