Fix failing coveralls script. #265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamestalmage
force-pushed
the
fix-coverage-2
branch
2 times, most recently
from
2e64378 to
04af8f0
Compare
For PR's `process.env.COVERALLS_REPO_TOKEN` does not exist, so `tap` will not automatically send data to coveralls. Hence our existing script: `npm run coveralls`. Unfortuneately that seems to create problems to create problems when merged onto master. In that case `tap` **will** automatically push our coverage data, and the follow up push seems to fail. To fix all this, I check the environment variable in .travis.yaml, and manually push the coverage data if the environment variable does not exist. https://travis-ci.org/sindresorhus/ava/jobs/92855751
jamestalmage
force-pushed
the
fix-coverage-2
branch
from
04af8f0 to
1816f73
Compare
jamestalmage
added a commit
that referenced
this pull request
Nov 24, 2015
Fix failing coveralls script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For PR's
process.env.COVERALLS_REPO_TOKENdoes not exist, sotapwill not automatically send data to coveralls. Hence our existing script:
npm run coveralls. Unfortuneately that seems to create problemswhen merged onto master. In that case
tapwillautomatically push our coverage data, and the follow up script seems to fail.
To fix all this, I check the environment variable in .travis.yaml, and
manually push the coverage data if the environment variable does not exist.
Example Failing Build:
https://travis-ci.org/sindresorhus/ava/jobs/92855751