Use tap.match in unit tests
#331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM |
1 similar comment
Contributor
|
LGTM |
Contributor
|
@sotojuan Could you please squash 2 commits into one? |
Use tap.match() instead of tap.true() in CLI tests
Contributor
Author
|
The commit message is a little weird, but I got it (had never squashed commits so I figured I'd play it safe). |
Contributor
|
@sotojuan What's wrong with the commit message? It is totally fine. |
vadimdemedes
pushed a commit
that referenced
this pull request
Dec 13, 2015
Use `t.match` instead of `t.true` in tests
Contributor
|
Thank you @sotojuan, keep those PRs coming! |
Contributor
Author
|
Oh I guess it's fine then (just thought it was curious that the message for the CLI one was in the long description part). Thanks and I will! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps out with #256 by converting the regex
t.true()tests intot.match().Let me know if I missed any!