Use AvaError for internal errors #371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM |
1 similar comment
Contributor
|
LGTM |
jamestalmage
force-pushed
the
internal-error
branch
from
18dc185 to
ac468d1
Compare
Member
|
LGTM |
jamestalmage
added a commit
that referenced
this pull request
Dec 27, 2015
Use AvaError for internal errors
Contributor
|
Hey, @jamestalmage, @sindresorhus: just a thought, should |
Member
|
No, the stack could still be useful. We rather check the type when outputting the error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #368.
Now we use
AvaErrorfor internal errors, that don't need a stack trace.