Include actual and expected when the number of assertions doesn't match the plan.

[ariporad]

This isn't as good as it could be, as it doesn't have a nice assertion diff, because that's generated by power assert, which does all kinds of other things too that we don't want

Fixes #102.

@sindresorhus, @jamestalmage, @vdemedes: thoughs?

[sindresorhus]

Could be more succinct. Something like, but better:

Assertion count of 4 does not match planned of 5

[ariporad]

@sindresorhus: It's not related to the stack. Check my comment in #102. It's a power-assert thing.

[ariporad]

@sindresorhus: Message fixed.

[jamestalmage]

Just wondering here. Now that #371 is merged, should we just use that for this? Is a stack trace really going to be that helpful? Especially since test.exit() is now always deferred via a promise?

[sindresorhus]

@jamestalmage I would still want to know which assertion and test that triggers the "incorrect plan count error".

[jamestalmage]

We would be setting it via test._setAssertError, so we will still know which test triggered that.
We currently only check the assert count when the test exits, not for every assert, so you currently can't know which assertion put you over the limit now.

(test._setAssertError is a bit of a misnomer now).

[ariporad]

@sindresourhus, @jamestalmage: yeah, I think we probably should. I'll work on that in the morning.

[jamestalmage]

@ariporad - How close are you to finishing this?

[ariporad]

@jamestalmage, @sindresorhus: OK, rebased onto master, and now uses AvaError.

[sindresorhus]

Tests are failing.

[ariporad]

@sindresorhus: Of course they are. Give me a second.

[ariporad]

Naturally, They're all false negatives.

@sindresorhus: Do AvaError's need .operators, .actuals or .expecteds?

[ariporad]

@jamestalmage: ^^^^^^^^^^

[sindresorhus]

@ariporad Sorry, missed this one. Can you rebase on master and fix the merge conflict?

Do AvaError's need .operators, .actuals or .expecteds?

No

[sindresorhus]

So, what should we do about this PR?

[sindresorhus]

Would like to see this land, but closing for now to clean up inactive PRs. @ariporad Feel free to do a new one if you ever have time ;)