Improve test scripts #385
Merged
Improve test scripts #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
|
This uses `nyc` directly instead of via `tap`. There is currently some semver brokeness happening due to a major version bump in `nyc` making it's way into a minor version bump for `tap`. I think the easiest solution is just to avoid the problem altogether by turning off `tap`s coverage option and using `nyc` directly. Reference: tapjs/tapjs#197 --- This also switches us to the `classic` reporter. Historically were using `dots` reporter with `tape`, but that provided poor diagnostic information on failures. The `classic` reporter does a much better job of providing all the information we need when a test fails.
jamestalmage
force-pushed
the
better-test-scripts
branch
from
fa41068 to
e1b2508
Compare
Contributor
Author
|
I was under the (very mistaken) impression that would not work following |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses
nycdirectly instead of viatap. There is currently some semver brokeness happening due to a major version bump innycmaking it's way into a minor version bump fortap. I think the easiest solution is just to avoid the problem altogether by turning offtaps coverage option and usingnycdirectly.Reference:
tapjs/tapjs#197
This also switches us to the
classicreporter. Historically were usingdotsreporter withtape, but that provided poor diagnostic information on failures. Theclassicreporter does a much better job of providing all the information we need when a test fails.