Skip to content

Fix t.throws/doesNotThrow not outputting failure reason #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Fix t.throws/doesNotThrow not outputting failure reason #414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2cdaad0
fix how throws method handles rejects
therealklanni Jan 9, 2016
ba2fb14
add string reject tests
therealklanni Jan 10, 2016
02bf5ac
use instanceof
therealklanni Jan 10, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/assert.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,11 @@ x.throws = function (fn, err, msg) {
x.throws(noop, err, msg);
}, function (fnErr) {
x.throws(function () {
throw fnErr;
if (fnErr instanceof Error) {
throw fnErr;
} else {
throw new Error(fnErr);
}
}, err, msg);
});
}
Expand Down
24 changes: 24 additions & 0 deletions test/promise.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,30 @@ test('handle throws with string', function (t) {
});
});

test('handle throws with regex with string reject', function (t) {
ava(function (a) {
a.plan(1);

var promise = Promise.reject('abc');
return a.throws(promise, /abc/);
}).run().then(function (a) {
t.notOk(a.assertionError);
t.end();
});
});

test('handle throws with string with string reject', function (t) {
ava(function (a) {
a.plan(1);

var promise = Promise.reject('abc');
return a.throws(promise, 'abc');
}).run().then(function (a) {
t.notOk(a.assertionError);
t.end();
});
});

test('handle throws with false-positive promise', function (t) {
ava(function (a) {
a.plan(1);
Expand Down