Set ecmaVersion to 2017
#153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think the reason we set it is that AVA uses Babel, so you can use the latest syntax without setting anything. We should always have this to the latest mode ESLint provides. We've already planned a breaking release, so can include this then. |
Would be cool if they accepted |
|
@SimenB Indeed. Open an issue on ESLint ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably a reason you haven't done it yet (other than the fact it's a breaking change), but it's annoying having ava override our setting just because we want to use recommended config, which means we have to specify
ecmaVersionmultiple places (as we only have ava in test dirs)An idea might be to drop the version entirely from recommended? That's still breaking, though.
Could do
require('eslint/package.json').versionand check if it's new enough to keep it non-breaking?