Support t.like() assertion #306
Conversation
Supports like() in use-t-well.
prefer-power-assert allows asserts "with no power-assert alternative"; like() appears to be one such assertion.
|
@ninevra I haven't had a chance to look at this yet, sorry. From your PR description everything sounds great though. Good job thinking of
It shouldn't be that straight-forward to enable an experiment 😉 For |
Place t.like() tests between t.is() and t.not() in alphabetically-ordered blocks, and after t.deepEqual() and t.notDeepEqual() in structurally-ordered blocks.
|
I noticed the placement of the new test cases clashed with the ordering of the existing test cases. Refactored a bit to fix this, no functional changes. |
|
I wasn't online much this weekend so I haven't been able to look at this yet, sorry. |
|
Looks great, thanks @ninevra! |
2 participants
Adds support for the
like()assertion to theassertion-arguments,use-t-well, andprefer-power-assertrules.For
prefer-power-assert, I addedlike()to the list of allowed assertions.prefer-power-assertsays it allows assertions with no power-assert equivalent, and I don't think there is such an equivalent.prefer-power-assertalso allowsdeepEqual(), upon whichlike()is based.I didn't find any other rules that need special support for
like().One additional thing that might be useful for
like()support would be a rule ensuring that, if any non-semver experiments are used, thenava's config properly enables them andpackage.jsonpinsavato a specific version instead of using a semver range. I'm not sure how practical this is and in any case I think it would be a subject for another pr.Closes #302, hopefully.