fix(ci): skip bash-dependent tests on Windows and add job timeout#105
Merged
emal-avala merged 1 commit intomainfrom Apr 15, 2026
Merged
fix(ci): skip bash-dependent tests on Windows and add job timeout#105emal-avala merged 1 commit intomainfrom
emal-avala merged 1 commit intomainfrom
Conversation
The shell passthrough integration tests spawn `bash -c` subprocesses which hang indefinitely on Windows runners (no bash available), causing the Test (windows-latest) job to run for 6 hours until GitHub cancels it. Skip these tests on Windows with cfg_attr ignore and add a 15-minute timeout as a safety net.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#[cfg_attr(target_os = "windows", ignore)]) — they spawnbash -cwhich doesn't exist on Windows runners, causing a 6-hour hang until GitHub cancels the jobtimeout-minutes: 15to the test job as a safety netRoot cause:
run_and_capture()callsCommand::new("bash")which hangs indefinitely on Windows CI runners.Test plan
ignoredstatus