ci: add minimum workflow permissions (CodeQL)#113
Merged
emal-avala merged 1 commit intomainfrom Apr 15, 2026
Merged
Conversation
…-permissions) Adds `permissions: contents: read` at the workflow level to ci.yml, client-ci.yml, and client-e2e.yml. These workflows only checkout code and run tests/builds — no writes to the repo or issues required. Explicitly declaring minimum permissions resolves the 7 open CodeQL alerts for actions/missing-workflow-permissions and follows the least-privilege best practice. The other workflows (release.yml, release-e2e.yml, docker.yml, docs.yml, evals-*.yml, client-release.yml, client-playwright.yml) already declare permissions.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves 7 open CodeQL alerts for
actions/missing-workflow-permissionsby addingpermissions: contents: readat the workflow level to:These workflows only checkout code and run tests/builds — no writes to the repo, issues, packages, or pages are required. Explicitly declaring minimum permissions follows the GitHub Actions least-privilege best practice and matches what the other workflows in this repo already do (release.yml, release-e2e.yml, docker.yml, docs.yml, evals-*.yml, client-release.yml, client-playwright.yml).
Remaining CodeQL alerts (not addressed here)
15 Rust alerts remain. All of them are false positives that I'll dismiss separately via the API with reason `false_positive`:
Test plan