fix(lib): replace sort_by with sort_by_key for clippy 1.95#133
Merged
emal-avala merged 2 commits intomainfrom Apr 16, 2026
Merged
fix(lib): replace sort_by with sort_by_key for clippy 1.95#133emal-avala merged 2 commits intomainfrom
emal-avala merged 2 commits intomainfrom
Conversation
Rust 1.95's unnecessary_sort_by lint rejects `sort_by(|a, b| b.X.cmp(&a.X))` in favor of `sort_by_key(|x| std::cmp::Reverse(x.X))`. Fixes four violations breaking CI's Clippy job on main.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Clippy 1.95's collapsible_match lint rejects a match arm whose body is a
single `if`. Semantically equivalent because the outer match has a `_ => {}`
catch-all — when the guard is false, Event::End(TagEnd::Item) hits that
no-op arm instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rust 1.95's
unnecessary_sort_byclippy lint rejectssort_by(|a, b| b.X.cmp(&a.X))in favor ofsort_by_key(|x| std::cmp::Reverse(x.X)). Four violations were breaking the Clippy job in CI on `main`.Files touched:
Test plan