Skip to content

feat(skills): add simplify bundled skill#158

Merged
emal-avala merged 4 commits intomainfrom
feat/skill-simplify
Apr 22, 2026
Merged

feat(skills): add simplify bundled skill#158
emal-avala merged 4 commits intomainfrom
feat/skill-simplify

Conversation

@emal-avala
Copy link
Copy Markdown
Member

Summary

Adds `/simplify` — runs a review-then-simplify pass on the current diff. Flags things the repo's house style calls dead weight:

  • Unused imports, variables, dead branches
  • Redundant helpers, single-caller traits, premature generics
  • Speculative error handling (try/catch around infallible code, validation for type-enforced invariants)
  • Defensive copies of immutable data
  • Comments that restate the code

For each, reports file:line + concrete fix. Stays inside the diff; doesn't invent abstractions; calls out anything load-bearing-but-non-obvious instead of touching it.

Why

Complements `/review` (which hunts for bugs/security issues) — this one hunts for code that shouldn't exist. Runs the same lens the house style doc prescribes ("Three similar lines is better than a premature abstraction", "Default to writing no comments", "Don't add error handling for scenarios that can't happen") so you don't have to rewrite the lens in every invocation.

Test plan

  • `cargo fmt --all` clean
  • `cargo check` passes
  • `cargo test -p agent-code-lib --lib skills` (all pass)
  • Manual: stage a diff that includes a `// this is a helper that` comment and unused import → `/simplify` flags both

A review-then-simplify pass targeted at the current diff: flag dead
branches, unused imports, premature abstractions, speculative error
handling, defensive copies, and comments that restate the code. For
each finding, cite file:line, explain why it's dead weight, and
propose the concrete removal.

Constraints baked into the prompt: stay inside the diff, don't
invent new abstractions, don't touch anything load-bearing that
isn't obvious from reading — call it out instead.
@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@emal-avala emal-avala merged commit 3d1bec7 into main Apr 22, 2026
13 of 14 checks passed
@emal-avala emal-avala deleted the feat/skill-simplify branch April 22, 2026 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant