Fix all clippy lints for CI#2
Merged
emal-avala merged 1 commit intomainfrom Mar 31, 2026
Merged
Conversation
Resolved 11 clippy warnings: - Collapsed identical if branches in context_window_for_model - Replaced &PathBuf with &Path in function signatures - Replaced manual Iterator::find loops with .find() - Allowed large_enum_variant on transport (intentional design) - Allowed enum_variant_names on RawDelta (SSE protocol names) - Fixed indexed loop variables to use enumerate - cargo fmt applied CI should now pass all 4 jobs: check, test, format, clippy.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
3 tasks
emal-avala
added a commit
that referenced
this pull request
Apr 23, 2026
The Test (windows-latest) job has been cancelling every PR at its 15-minute timeout since the schedule subcommand landed. Two separate Windows-specific problems: 1. Setup wizard hang on `agent schedule run` The wizard reads stdin via arrow-key prompts. On Windows CI, stdin isn't a TTY and the wizard blocks indefinitely. Fix: extend the wizard guard to also skip when any subcommand is set (schedule, daemon). Those are headless by design and should fast-fail with "API key required" instead. 2. Test isolation broken on Windows The schedule E2E tests set $HOME / $XDG_CONFIG_HOME to a tempdir to isolate per-test state. On Linux that works — `dirs::config_dir` reads those env vars. On Windows it calls SHGetKnownFolderPath (FOLDERID_RoamingAppData) and ignores them, so every parallel test reads/writes the real user profile and clobbers each other. Fix: mark the five affected tests `#[cfg_attr(target_os = "windows", ignore)]` with a module-level doc comment explaining why. Linux CI remains the source of truth for these tests. Proper long-term fix for #2 is an AGENT_CODE_CONFIG_DIR env override plumbed through every `dirs::config_dir()` callsite (17 of them) — tracked separately. Tests on Linux: 14/14 schedule tests pass.
emal-avala
added a commit
that referenced
this pull request
Apr 23, 2026
The Test (windows-latest) job has been cancelling every PR at its 15-minute timeout since the schedule subcommand landed. Two separate Windows-specific problems: 1. Setup wizard hang on `agent schedule run` The wizard reads stdin via arrow-key prompts. On Windows CI, stdin isn't a TTY and the wizard blocks indefinitely. Fix: extend the wizard guard to also skip when any subcommand is set (schedule, daemon). Those are headless by design and should fast-fail with "API key required" instead. 2. Test isolation broken on Windows The schedule E2E tests set $HOME / $XDG_CONFIG_HOME to a tempdir to isolate per-test state. On Linux that works — `dirs::config_dir` reads those env vars. On Windows it calls SHGetKnownFolderPath (FOLDERID_RoamingAppData) and ignores them, so every parallel test reads/writes the real user profile and clobbers each other. Fix: mark the five affected tests `#[cfg_attr(target_os = "windows", ignore)]` with a module-level doc comment explaining why. Linux CI remains the source of truth for these tests. Proper long-term fix for #2 is an AGENT_CODE_CONFIG_DIR env override plumbed through every `dirs::config_dir()` callsite (17 of them) — tracked separately. Tests on Linux: 14/14 schedule tests pass.
emal-avala
added a commit
that referenced
this pull request
Apr 23, 2026
The Test (windows-latest) job has been cancelling every PR at its 15-minute timeout since the schedule subcommand landed. Two separate Windows-specific problems: 1. Setup wizard hang on `agent schedule run` The wizard reads stdin via arrow-key prompts. On Windows CI, stdin isn't a TTY and the wizard blocks indefinitely. Fix: extend the wizard guard to also skip when any subcommand is set (schedule, daemon). Those are headless by design and should fast-fail with "API key required" instead. 2. Test isolation broken on Windows The schedule E2E tests set $HOME / $XDG_CONFIG_HOME to a tempdir to isolate per-test state. On Linux that works — `dirs::config_dir` reads those env vars. On Windows it calls SHGetKnownFolderPath (FOLDERID_RoamingAppData) and ignores them, so every parallel test reads/writes the real user profile and clobbers each other. Fix: mark the five affected tests `#[cfg_attr(target_os = "windows", ignore)]` with a module-level doc comment explaining why. Linux CI remains the source of truth for these tests. Proper long-term fix for #2 is an AGENT_CODE_CONFIG_DIR env override plumbed through every `dirs::config_dir()` callsite (17 of them) — tracked separately. Tests on Linux: 14/14 schedule tests pass.
emal-avala
added a commit
that referenced
this pull request
Apr 23, 2026
The Test (windows-latest) job has been cancelling every PR at its 15-minute timeout since the schedule subcommand landed. Two separate Windows-specific problems: 1. Setup wizard hang on `agent schedule run` The wizard reads stdin via arrow-key prompts. On Windows CI, stdin isn't a TTY and the wizard blocks indefinitely. Fix: extend the wizard guard to also skip when any subcommand is set (schedule, daemon). Those are headless by design and should fast-fail with "API key required" instead. 2. Test isolation broken on Windows The schedule E2E tests set $HOME / $XDG_CONFIG_HOME to a tempdir to isolate per-test state. On Linux that works — `dirs::config_dir` reads those env vars. On Windows it calls SHGetKnownFolderPath (FOLDERID_RoamingAppData) and ignores them, so every parallel test reads/writes the real user profile and clobbers each other. Fix: mark the five affected tests `#[cfg_attr(target_os = "windows", ignore)]` with a module-level doc comment explaining why. Linux CI remains the source of truth for these tests. Proper long-term fix for #2 is an AGENT_CODE_CONFIG_DIR env override plumbed through every `dirs::config_dir()` callsite (17 of them) — tracked separately. Tests on Linux: 14/14 schedule tests pass.
emal-avala
added a commit
that referenced
this pull request
Apr 23, 2026
The Test (windows-latest) job has been cancelling every PR at its 15-minute timeout since the schedule subcommand landed. Two separate Windows-specific problems: 1. Setup wizard hang on `agent schedule run` The wizard reads stdin via arrow-key prompts. On Windows CI, stdin isn't a TTY and the wizard blocks indefinitely. Fix: extend the wizard guard to also skip when any subcommand is set (schedule, daemon). Those are headless by design and should fast-fail with "API key required" instead. 2. Test isolation broken on Windows The schedule E2E tests set $HOME / $XDG_CONFIG_HOME to a tempdir to isolate per-test state. On Linux that works — `dirs::config_dir` reads those env vars. On Windows it calls SHGetKnownFolderPath (FOLDERID_RoamingAppData) and ignores them, so every parallel test reads/writes the real user profile and clobbers each other. Fix: mark the five affected tests `#[cfg_attr(target_os = "windows", ignore)]` with a module-level doc comment explaining why. Linux CI remains the source of truth for these tests. Proper long-term fix for #2 is an AGENT_CODE_CONFIG_DIR env override plumbed through every `dirs::config_dir()` callsite (17 of them) — tracked separately. Tests on Linux: 14/14 schedule tests pass.
emal-avala
added a commit
that referenced
this pull request
Apr 23, 2026
The Test (windows-latest) job has been cancelling every PR at its 15-minute timeout since the schedule subcommand landed. Two separate Windows-specific problems: 1. Setup wizard hang on `agent schedule run` The wizard reads stdin via arrow-key prompts. On Windows CI, stdin isn't a TTY and the wizard blocks indefinitely. Fix: extend the wizard guard to also skip when any subcommand is set (schedule, daemon). Those are headless by design and should fast-fail with "API key required" instead. 2. Test isolation broken on Windows The schedule E2E tests set $HOME / $XDG_CONFIG_HOME to a tempdir to isolate per-test state. On Linux that works — `dirs::config_dir` reads those env vars. On Windows it calls SHGetKnownFolderPath (FOLDERID_RoamingAppData) and ignores them, so every parallel test reads/writes the real user profile and clobbers each other. Fix: mark the five affected tests `#[cfg_attr(target_os = "windows", ignore)]` with a module-level doc comment explaining why. Linux CI remains the source of truth for these tests. Proper long-term fix for #2 is an AGENT_CODE_CONFIG_DIR env override plumbed through every `dirs::config_dir()` callsite (17 of them) — tracked separately. Tests on Linux: 14/14 schedule tests pass.
emal-avala
added a commit
that referenced
this pull request
Apr 23, 2026
The Test (windows-latest) job has been cancelling every PR at its 15-minute timeout since the schedule subcommand landed. Two separate Windows-specific problems: 1. Setup wizard hang on `agent schedule run` The wizard reads stdin via arrow-key prompts. On Windows CI, stdin isn't a TTY and the wizard blocks indefinitely. Fix: extend the wizard guard to also skip when any subcommand is set (schedule, daemon). Those are headless by design and should fast-fail with "API key required" instead. 2. Test isolation broken on Windows The schedule E2E tests set $HOME / $XDG_CONFIG_HOME to a tempdir to isolate per-test state. On Linux that works — `dirs::config_dir` reads those env vars. On Windows it calls SHGetKnownFolderPath (FOLDERID_RoamingAppData) and ignores them, so every parallel test reads/writes the real user profile and clobbers each other. Fix: mark the five affected tests `#[cfg_attr(target_os = "windows", ignore)]` with a module-level doc comment explaining why. Linux CI remains the source of truth for these tests. Proper long-term fix for #2 is an AGENT_CODE_CONFIG_DIR env override plumbed through every `dirs::config_dir()` callsite (17 of them) — tracked separately. Tests on Linux: 14/14 schedule tests pass.
emal-avala
added a commit
that referenced
this pull request
Apr 23, 2026
The Test (windows-latest) job has been cancelling every PR at its 15-minute timeout since the schedule subcommand landed. Two separate Windows-specific problems: 1. Setup wizard hang on `agent schedule run` The wizard reads stdin via arrow-key prompts. On Windows CI, stdin isn't a TTY and the wizard blocks indefinitely. Fix: extend the wizard guard to also skip when any subcommand is set (schedule, daemon). Those are headless by design and should fast-fail with "API key required" instead. 2. Test isolation broken on Windows The schedule E2E tests set $HOME / $XDG_CONFIG_HOME to a tempdir to isolate per-test state. On Linux that works — `dirs::config_dir` reads those env vars. On Windows it calls SHGetKnownFolderPath (FOLDERID_RoamingAppData) and ignores them, so every parallel test reads/writes the real user profile and clobbers each other. Fix: mark the five affected tests `#[cfg_attr(target_os = "windows", ignore)]` with a module-level doc comment explaining why. Linux CI remains the source of truth for these tests. Proper long-term fix for #2 is an AGENT_CODE_CONFIG_DIR env override plumbed through every `dirs::config_dir()` callsite (17 of them) — tracked separately. Tests on Linux: 14/14 schedule tests pass.
emal-avala
added a commit
that referenced
this pull request
Apr 23, 2026
The Test (windows-latest) job has been cancelling every PR at its 15-minute timeout since the schedule subcommand landed. Two separate Windows-specific problems: 1. Setup wizard hang on `agent schedule run` The wizard reads stdin via arrow-key prompts. On Windows CI, stdin isn't a TTY and the wizard blocks indefinitely. Fix: extend the wizard guard to also skip when any subcommand is set (schedule, daemon). Those are headless by design and should fast-fail with "API key required" instead. 2. Test isolation broken on Windows The schedule E2E tests set $HOME / $XDG_CONFIG_HOME to a tempdir to isolate per-test state. On Linux that works — `dirs::config_dir` reads those env vars. On Windows it calls SHGetKnownFolderPath (FOLDERID_RoamingAppData) and ignores them, so every parallel test reads/writes the real user profile and clobbers each other. Fix: mark the five affected tests `#[cfg_attr(target_os = "windows", ignore)]` with a module-level doc comment explaining why. Linux CI remains the source of truth for these tests. Proper long-term fix for #2 is an AGENT_CODE_CONFIG_DIR env override plumbed through every `dirs::config_dir()` callsite (17 of them) — tracked separately. Tests on Linux: 14/14 schedule tests pass.
emal-avala
added a commit
that referenced
this pull request
Apr 23, 2026
The Test (windows-latest) job has been cancelling every PR at its 15-minute timeout since the schedule subcommand landed. Two separate Windows-specific problems: 1. Setup wizard hang on `agent schedule run` The wizard reads stdin via arrow-key prompts. On Windows CI, stdin isn't a TTY and the wizard blocks indefinitely. Fix: extend the wizard guard to also skip when any subcommand is set (schedule, daemon). Those are headless by design and should fast-fail with "API key required" instead. 2. Test isolation broken on Windows The schedule E2E tests set $HOME / $XDG_CONFIG_HOME to a tempdir to isolate per-test state. On Linux that works — `dirs::config_dir` reads those env vars. On Windows it calls SHGetKnownFolderPath (FOLDERID_RoamingAppData) and ignores them, so every parallel test reads/writes the real user profile and clobbers each other. Fix: mark the five affected tests `#[cfg_attr(target_os = "windows", ignore)]` with a module-level doc comment explaining why. Linux CI remains the source of truth for these tests. Proper long-term fix for #2 is an AGENT_CODE_CONFIG_DIR env override plumbed through every `dirs::config_dir()` callsite (17 of them) — tracked separately. Tests on Linux: 14/14 schedule tests pass.
emal-avala
added a commit
that referenced
this pull request
Apr 23, 2026
The Test (windows-latest) job has been cancelling every PR at its 15-minute timeout since the schedule subcommand landed. Two separate Windows-specific problems: 1. Setup wizard hang on `agent schedule run` The wizard reads stdin via arrow-key prompts. On Windows CI, stdin isn't a TTY and the wizard blocks indefinitely. Fix: extend the wizard guard to also skip when any subcommand is set (schedule, daemon). Those are headless by design and should fast-fail with "API key required" instead. 2. Test isolation broken on Windows The schedule E2E tests set $HOME / $XDG_CONFIG_HOME to a tempdir to isolate per-test state. On Linux that works — `dirs::config_dir` reads those env vars. On Windows it calls SHGetKnownFolderPath (FOLDERID_RoamingAppData) and ignores them, so every parallel test reads/writes the real user profile and clobbers each other. Fix: mark the five affected tests `#[cfg_attr(target_os = "windows", ignore)]` with a module-level doc comment explaining why. Linux CI remains the source of truth for these tests. Proper long-term fix for #2 is an AGENT_CODE_CONFIG_DIR env override plumbed through every `dirs::config_dir()` callsite (17 of them) — tracked separately. Tests on Linux: 14/14 schedule tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo clippy -- -D warningsnow passes cleanTest plan
cargo testpasses (31 tests)cargo clippyclean (0 warnings)cargo fmtapplied