fix(ci): unblock main — cfg-gate unix-only test + add missing ToolContext field#264
Merged
Conversation
backup_rotation_does_not_run_when_atomic_write_fails uses std::os::unix::fs::PermissionsExt::set_mode to simulate an atomic write failure by dropping directory mode to 0o555. Without a #[cfg(unix)] gate the test fails to compile on Windows with E0433 (cannot find unix in os) and E0599 (no method named set_mode on Permissions). The other three POSIX-mode tests in this file are already gated; this one was missed when #255 landed.
…literals #263 (task model variants) was based on main before #256 (output styles from disk) added active_disk_output_style to ToolContext. After both landed, three ToolContext literals in the task subsystem fail to compile with E0063. Add the field with None to: - crates/lib/src/tools/tasks/executors/local_agent.rs:75 - crates/lib/src/tools/tasks/tools.rs (test helper) - crates/lib/tests/task_kind_integration.rs:34 Task executors don't propagate disk output styles today; None is the correct value until 8.7 (swarm mode) and 8.10 (fork/resume) wire that through.
emal-avala
changed the title
emal-avala
added a commit
that referenced
this pull request
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two unrelated fixes that together unblock CI on `main`:
Windows compile — `backup_rotation_does_not_run_when_atomic_write_fails` in `crates/lib/tests/config_migrations.rs` uses `std::os::unix::fs::PermissionsExt::set_mode` to drop a directory's mode and simulate an atomic-write failure. Without a `#[cfg(unix)]` gate, Windows builds fail with E0433/E0599. Other POSIX-mode tests in the same file are already gated; this one was missed when feat: settings migrations framework #255 landed.
Ubuntu compile — feat: task model variants #263 (task model variants) was based on `main` before feat: load output styles from disk #256 (disk output styles) added `active_disk_output_style` to `ToolContext`. After both landed, three `ToolContext` literals in the task subsystem fail to compile with E0063. Adds the field with `None` to:
Task executors don't propagate disk output styles today; `None` is the correct value until 8.7 (swarm mode) and 8.10 (fork/resume) wire that through.
Test plan