perf: hit v1.0 performance targets#70
Merged
emal-avala merged 3 commits intomainfrom Apr 6, 2026
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Startup (<150ms): - Move blocking API key validation (sync curl, 5s timeout) to async background task with 500ms non-blocking window - Reduce curl timeout from 5s to 3s - Key check no longer blocks interactive startup Binary size (<12MB): - Add codegen-units=1 and panic=abort to release profile - Narrow tokio features from "full" to specific needed features in both lib and cli crates (saves ~2-3MB) Tests (494, target was 400+): - Add 269 new tests across 20 files (was 225, now 494) - New inline test modules for error types, config schema, memory types - Extended tests for providers, permissions, messages, normalization, retry logic, token estimation, compaction, pricing, bash parsing - New integration tests: permissions, messages, provider detection - Add startup benchmark (config loading latency) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Run cargo fmt on all files - Fix clippy warnings: collapsible if, unnecessary unwrap, needless borrow, unused variable, returning let binding - Add missing config_cli.rs integration test file and toml dev-dep - All checks pass: fmt, clippy -D warnings, test -D warnings Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
emal-avala
force-pushed
the
perf/v1-targets
branch
from
6e96e23 to
fee0f5c
Compare
Adding the 'run-e2e' label to a PR now triggers the E2E test suite automatically. Tag pushes and manual dispatch continue to work as before. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
emal-avala
added a commit
that referenced
this pull request
Apr 6, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codegen-units=1,panic=abortto release profile; narrowed tokio features from"full"to specific needed featuresTest plan
cargo check— zero warnings, zero errorscargo test— 494 tests passingcargo clippy— no new errors (only pre-existing style warnings)cargo build --release— verify binary size reduction on CItime agent --help🤖 Generated with Claude Code