fix(e2e): remove local keyword outside function scope in D10 test#85
Merged
emal-avala merged 1 commit intomainfrom Apr 7, 2026
Merged
fix(e2e): remove local keyword outside function scope in D10 test#85emal-avala merged 1 commit intomainfrom
emal-avala merged 1 commit intomainfrom
Conversation
`local` is only valid inside bash functions. Using it in the top-level `else` block caused two cascading failures: 1. `local: can only be used in a function` (line 569) 2. `d10_passed: unbound variable` (line 600, because the local declaration failed silently in some shells but set -u catches it) Fix: use plain variable assignment instead of `local`.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One-line fix for the release E2E test failure at https://github.com/avala-ai/agent-code/actions/runs/24055333562/job/70160116608
Root cause:
local d10_passed=falseon line 569 ofscripts/e2e-tests.shis inside anelseblock, not a function. Bash rejectslocaloutside functions, which causes:local: can only be used in a functionerrord10_passed: unbound variableon line 600 (because the declaration failed andset -uis active)Fix:
local d10_passed=false→d10_passed=falseTest plan
bash -n scripts/e2e-tests.sh— syntax check passes🤖 Generated with Claude Code