Improve coverage for reader classes #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although these gave some indication of the behaviour of the method, they weren't wholly accurate: passing a boolean of "False" to the method would return an Iterable[ObsData], not an Iterable[RawData]. We can be more descriptive with a docstring instead.
Coverage for these lines was added in [^1]. [^1]: 20a420f
avaldebe
requested changes
Nov 7, 2022
Owner
avaldebe
left a comment
avaldebe
left a comment
There was a problem hiding this comment.
Thanks again for this PR. I really appreciate the additional tests.
Please consider my comments about indirect parameterization and the use of fixtures in order to keep the test setup outside the test function.
Although this is partially covered by the functional tests of the CLI [^1], this test adds more coverage by not specifying a limit of the samples to collect. [^1]: https://github.com/benthorner/PyPMS/blob/f71628418e4a9d4ab89eea356926b4f158a76e7a/tests/test_cli.py#L32-L45
This standardises the "closed" behaviour between both reader classes.
avaldebe
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows on from: #29
In attempting to refactor the reader classes I found it
useful to have even more tests than those I proposed
previously. Rather than have a huge "refactoring" PR
I thought it would be better to propose them first.
Note: the first commit isn't related to coverage but is
also a bit tangential to the refactoring, so added here.