Inspector: replace bind toggle with inline binding chip#17
Merged
Conversation
The old per-attribute bind UI lived as a full row beneath each widget — a 🔗 button, a bound-label row, or an expanded picker depending on state. Vertical noise on every attribute, and the bind affordance sat far from the label it modified. The chip moves the affordance inline with the field label: - Unbound: small 🔗 button on the label row. - Bound: rounded pill with "↔ owner.field" + × to unbind. - Click chip → the picker panel pops up below the widget; pick a field → panel hides and the binding commits in two clicks. Same model for both attribute bindings and text-content (:text-field) bindings, so the visual language is one. The picker logic (`build-bind-picker-panel`) is unchanged — only the trigger surface moves. `attr-binding-label` and `text-bind-label` are extracted as pure helpers and exposed for unit tests; five new deftests pin the label format for the explicit-owner, doc-walk-fallback, and missing-owner cases. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build-bind-togglefor attributes,build-text-content-bindfor text) with a single reusablebind-chip-and-popoverfactory.attr-binding-label,text-bind-label) — pure, unit-tested.Test plan
clj-kondo --lint src test scripts— 0/0cljfmt check— cleannpx shadow-cljs compile test— 589 tests / 1818 assertions, 0 failnpx shadow-cljs release app— 0 warnings🤖 Generated with Claude Code