Phase 1.4: migrate generators to lower-document consumption

[avanelsas]

Summary

Lands the final piece of the Hickey-style refactor roadmap (audit

• sub emitters in Hickey-style refactor roadmap: 4 of 6 audit items landed #20, inspector field-as-data in Step 6 (phases 6.1+6.2): inspector field-as-data — coerce extraction + spec contract #21, hiccup
  event emitters in Phase 1.3a: migrate event emitters to clj_form data #23, hiccup data migration in Phase 1.3b: migrate node->hiccup-with-events to clj_form data #24). Every export
  plugin's per-group generators now consume the canonical lowered
  representation produced once at the entry point — no more
  re-deriving group classification, field owners, name→ns maps, or
  per-group :data inside each generator.

One commit, all four CI gates green, 747 tests passing.

What's in this PR

cljs_project.cljs

• Top-level generate calls em/lower-document once and threads
  the result as lowered to every per-group generator.
• generate-db / generate-subs / generate-events / generate-views / generate-core / generate-root-db switch from
  (collect-group-data doc instance-ids all-groups) to (:data g),
  from (template-group? doc g) to (:template? g), from
  (stateful-group? doc g) to (not (:template? g)), and from
  inline (field-owner-index doc all-groups) /
  (name->ns-name-map doc all-groups) to the precomputed
  (:field-owner-ns lowered) / (:name->ns-name lowered).
• view-context (the data-assembly helper for views) loses its
  per-call template-names set / owner-idx / name->ns
  derivations — all three come off lowered.
• Five private aliases (collect-group-data, template-group?,
  stateful-group?, field-owner-index, name->ns-name-map)
  deleted — no longer referenced.

vanilla_js plugin

• plugin/generate calls lower-document once and threads it
  through assert-supported!, emit-app-js, and the four
  emit-group-* helpers.
• assert-supported! drops its doc parameter and walks
  (:data g) instead of re-deriving via collect-group-data.
• codegen/emit-group-db / -subs / -events / -views / -app-js
  consume :data / :template? / lowered :field-owner-ns /
  :template-names directly. The internal helper chain
  (field-of-group, step-mutator-expr, step-needs-qualify?,
  uses-qualify?, emit-action, source-field-of-group,
  template-view, stateful-view, template-sub-imports)
  cascades the same simplification — doc / all-groups drop
  out of signatures wherever the lowered data covers them.

Tests

vanilla_js_test's two assert-supported! call sites switch
from (em/detect-groups doc) + the old 2-arg signature to
(em/lower-document doc) + the new 1-arg signature. No other
test changed — the lowered output is byte-identical (same data
just resolved once instead of N times).

What this completes

After this PR, the Hickey-style refactor roadmap (#20 audit) is
fully landed. No outstanding items from that scope.

Test plan

• clj-kondo --lint src test scripts — 0 errors, 0 warnings
• cljfmt check — clean
• npx shadow-cljs compile test — 747 tests, 0 failures, 0 errors
• npx shadow-cljs release app — 0 warnings
• Output stays byte-identical — every existing fixture-driven
  substring/regex test passes unchanged.

Related

• PR Phase 1.3b: migrate node->hiccup-with-events to clj_form data #24 — Phase 1.3b hiccup data migration (merged)
• PR Phase 1.3a: migrate event emitters to clj_form data #23 — Phase 1.3a event emitters (merged)
• PR Step 6 (phases 6.1+6.2): inspector field-as-data — coerce extraction + spec contract #21 — Step 6 inspector field-as-data (merged)
• PR Hickey-style refactor roadmap: 4 of 6 audit items landed #20 — Hickey-style refactor roadmap audit + Phase 1.1/1.2
  sub emitters + lower-document definition (merged)

🤖 Generated with Claude Code