Fix Pages: relative paths for toolbar logo + CLJS export script#4
Merged
Conversation
Two more absolute paths missed by the earlier static-html fix:
- src/bareforge/ui/toolbar.cljs: brand <picture> used
/assets/bareforge_{darkmode,lightmode}.png. The deployed Pages
site at /bareforge/ resolved them to /assets/... at the user-pages
root → 404 → broken brand logo (visible in console errors on the
hosted demo).
- src/bareforge/export/cljs_project.cljs: the index.html the CLJS
export plugin emits hard-coded <script src="/js/main.js">. Same
bug shape — users hosting their exported project at a sub-path
would see a 404. Made relative to match the new convention.
The lingering <feGaussianBlur stdDeviation="var(--x-welcome-...">
warning in the console is upstream in BareDOM 2.4.0's
x-welcome-tour SVG markup (CSS variable bound to a numeric SVG
attribute that doesn't accept var()). SVG falls back to default
blur; cosmetic console noise, not a broken UI. Will file upstream.
All four gates green locally.
This was referenced May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two more absolute-path leaks the earlier static-html fix missed, both surfacing as 404s on the hosted Pages demo:
Toolbar brand logo (
src/bareforge/ui/toolbar.cljs):<source srcset=\"/assets/bareforge_darkmode.png\">and<img src=\"/assets/bareforge_lightmode.png\">. The Pages site at/bareforge/resolved them to the user-pages root (/assets/...→ 404) → broken brand logo. Console error visible to the user.CLJS export plugin's emitted index.html (
src/bareforge/export/cljs_project.cljs): hard-coded<script src=\"/js/main.js\">. Same bug shape — users hosting their exported project at a sub-path would see a 404. Made relative for consistency.What this does NOT fix
The
<feGaussianBlur stdDeviation=\"var(--x-welcome-...)\">warning visible alongside the 404 is upstream in BareDOM 2.4.0's x-welcome-tour SVG markup — a CSS variable bound to a numeric SVG attribute that doesn't acceptvar(). SVG ignores the bad value and falls back to default blur. Cosmetic console noise, not a functional bug. Will file upstream against BareDOM separately.Test plan
gh workflow run pages.ymlredeploy, the brand-logo 404 disappears from the deployed editor's console.