fix: stream string table to prevent OOM on malformed APKs#7
Merged
MiroslavDrbal merged 1 commit intomasterfrom Apr 22, 2026
Merged
fix: stream string table to prevent OOM on malformed APKs#7MiroslavDrbal merged 1 commit intomasterfrom
MiroslavDrbal merged 1 commit intomasterfrom
Conversation
Replace the old data[]byte + lazy-cache string table with a single-pass streaming decoder that clips strings to a configurable memory budget (default 50 MB). Strings exceeding the budget are truncated longest-first and marked with <TRUNCATED>. New public API: - ParseConfig struct for caller-controlled parser options - ParseXmlWithConfig / ParseResourceTableWithConfig - ApkParser.Config field - DefaultMaxStringTableBytes constant Existing ParseXml / ParseResourceTable signatures are unchanged. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the old data[]byte + lazy-cache string table with a single-pass streaming decoder that clips strings to a configurable memory budget (default 50 MB). Strings exceeding the budget are truncated longest-first and marked with .
New public API:
Existing ParseXml / ParseResourceTable signatures are unchanged.