Fix functional tests: replace smoke assertions with meaningful checks

[avandenberghe]

Summary

All five tests in tests/functional/recenttopics_test.php assert only $crawler->filter('html')->count() >= 1 — which passes as long as the page does not return a 500 error. These are smoke tests with no signal value.

Current state

Test	Current assertion	Problem
test_rt_page	html element exists	Passes even if RT block is empty or broken
test_rt_simple_page	html element exists	Same
test_rt_page_disabled	html element exists	Doesn't verify the block is actually hidden
test_index_has_recent_topics	html element exists	Creates a topic but never checks it appears
test_ucp_preferences	html element exists	Doesn't verify any RT-specific form fields

What the assertions should check

• test_rt_page / test_rt_simple_page — RT block is present in the response; at minimum a known CSS class or language string rendered by the RT template
• test_rt_page_disabled — the RT block is absent or a "disabled" state is shown
• test_index_has_recent_topics — the created topic title appears inside the RT block on the index page
• test_ucp_preferences — the UCP form contains the RT-specific fields (forum_recent_topics checkbox or equivalent)

Why this matters

The functional test suite currently gives false confidence. A broken template, a wrong config key, or a missing language string would all pass. Meaningful assertions make the suite worth running.

[avandenberghe]

Implemented

Rewrote all five tests in tests/functional/recenttopics_test.php. Every test now makes at least one meaningful assertion beyond html >= 1.

What each test now checks

Test	Assertions
test_rt_page	<a id="recent-topics"> exists (static anchor in template); <title> contains "Recent Topics"
test_rt_simple_page	<a id="recent-topics"> exists (static anchor in simple template)
test_rt_page_disabled	Anchor still present; #recent-topics-box is absent (topics loop not populated because controller skips display_recent_topics() when disabled)
test_index_has_recent_topics	Anchor present; #recent-topics-box present; created topic title "RT Functional Test Topic" appears inside the block
test_ucp_preferences	input[name="rt_enable"] and input[name="rt_number"] present (RT fields injected by the UCP template event)

What the assertions are anchored to

• <a id="recent-topics"> — static anchor at the top of every RT template file, outside the topic loop, so it is present regardless of whether there are topics to display
• #recent-topics-box — inside the {% for recent_topics %} loop; only rendered when the display loop has at least one row
• input[name="rt_enable"] — injected by ucp_prefs_view_select_menu_append.html when S_RT_SHOW is true (requires at least one u_rt_* permission)

Verification pending CI run on the develop33 branch.