Skip to content

Conversation

@jarbesfeld
Copy link
Collaborator

@jarbesfeld jarbesfeld commented Oct 1, 2024

  • Update analysis notebooks to reference the summary statistics in the updated preprint
  • Update alignment code to ensure correct BLAT parameters are being used and that the correct strand orientation is selected for protein coding DNA target sequences
  • Update vrs_map to skip protein mapping when only genomic variants should be mapped

@jarbesfeld jarbesfeld added the enhancement New feature or request label Oct 1, 2024
@jarbesfeld jarbesfeld requested a review from jsstevenson October 1, 2024 18:59
@jarbesfeld jarbesfeld self-assigned this Oct 1, 2024
@jsstevenson jsstevenson self-requested a review October 1, 2024 20:00
Copy link
Collaborator

@jsstevenson jsstevenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests still assume that the extra objects get created -- I think behavior is correct so we should update the expected values so that they pass in CI. Can work through that with you if it gives you trouble.

@jarbesfeld jarbesfeld requested a review from jsstevenson October 2, 2024 13:22
Copy link
Collaborator

@jsstevenson jsstevenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good, a couple small changes



def extract_potential_gene_symbol(word: str) -> str:
"""Remove paranetheses from a potential gene symbol
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blank line between the first sentence in the docstring and the first :param: line

@jsstevenson jsstevenson self-requested a review October 9, 2024 13:56
@jsstevenson
Copy link
Collaborator

looks like tests are failing now fyi

@jarbesfeld jarbesfeld requested a review from jsstevenson October 9, 2024 18:24
@jarbesfeld jarbesfeld requested a review from jsstevenson October 9, 2024 19:11
@jarbesfeld jarbesfeld merged commit 88e3078 into main Oct 10, 2024
@jarbesfeld jarbesfeld deleted the mave_mapping_testing branch October 10, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants