-
Notifications
You must be signed in to change notification settings - Fork 5
Update notebooks, alignment, and mapping code #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jsstevenson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests still assume that the extra objects get created -- I think behavior is correct so we should update the expected values so that they pass in CI. Can work through that with you if it gives you trouble.
jsstevenson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 looks good, a couple small changes
|
|
||
|
|
||
| def extract_potential_gene_symbol(word: str) -> str: | ||
| """Remove paranetheses from a potential gene symbol |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blank line between the first sentence in the docstring and the first :param: line
|
looks like tests are failing now fyi |
Uh oh!
There was an error while loading. Please reload this page.