Skip to content

Feature: implemented compact banner option for the wrapper#48

Merged
avelino merged 3 commits intoavelino:mainfrom
cereda:feature/compact-banner
Feb 24, 2026
Merged

Feature: implemented compact banner option for the wrapper#48
avelino merged 3 commits intoavelino:mainfrom
cereda:feature/compact-banner

Conversation

@cereda
Copy link
Contributor

@cereda cereda commented Jan 30, 2026

Implemented --compact-banner CLI flag as discussed in #39 (also available as compact_banner key in the config file).

When flag is present (or corresponding key set to true in the config file), jbundle should replace

   _ _                    _ _
  (_) |__  _   _ _ __   __| | | ___
  | | '_ \| | | | '_ \ / _` | |/ _ \
  | | |_) | |_| | | | | (_| | |  __/
 _/ |_.__/ \__,_|_| |_|\__,_|_|\___|
|__/

by

binary created with jbundle.avelino.run

in the application wrapper script (wording per author's suggestion).

Hope it works. Cheers! 😉

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for an optional compact startup banner in the generated wrapper, configurable via --compact-banner and compact_banner in jbundle.toml.

Changes:

  • Introduces compact_banner in CLI, build config, and project config loading.
  • Plumbs the option into the packer and stub generator, emitting a conditional banner in the wrapper script.
  • Updates CLI and configuration documentation to include the new option.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/cli.rs Adds --compact-banner flag to the build command.
src/main.rs Resolves compact_banner from CLI/config and passes it through the build pipeline.
src/config.rs Extends BuildConfig with compact_banner.
src/project_config.rs Adds compact_banner to jbundle.toml schema and test coverage for parsing.
src/pack/mod.rs Extends PackOptions and forwards compact_banner into stub generation.
src/pack/stub.rs Adds conditional compact-vs-ASCII banner behavior in the wrapper stub.
docs/reference/cli.md Documents the new --compact-banner option.
docs/guide/configuration.md Documents the new compact_banner configuration key.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Owner

@avelino avelino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@avelino
Copy link
Owner

avelino commented Feb 2, 2026

@cereda update to branch main

@koppor
Copy link
Contributor

koppor commented Feb 10, 2026

@cereda Please merge upstream/main and resolve conflicts.

@cereda
Copy link
Contributor Author

cereda commented Feb 10, 2026

@avelino @koppor apologies for the delay, friends. Last days have been hectic. 😅

And hi Oli! 😉

@avelino avelino merged commit 2d6cf07 into avelino:main Feb 24, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants