Feature: implemented compact banner option for the wrapper#48
Merged
avelino merged 3 commits intoavelino:mainfrom Feb 24, 2026
Merged
Feature: implemented compact banner option for the wrapper#48avelino merged 3 commits intoavelino:mainfrom
avelino merged 3 commits intoavelino:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for an optional compact startup banner in the generated wrapper, configurable via --compact-banner and compact_banner in jbundle.toml.
Changes:
- Introduces
compact_bannerin CLI, build config, and project config loading. - Plumbs the option into the packer and stub generator, emitting a conditional banner in the wrapper script.
- Updates CLI and configuration documentation to include the new option.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/cli.rs | Adds --compact-banner flag to the build command. |
| src/main.rs | Resolves compact_banner from CLI/config and passes it through the build pipeline. |
| src/config.rs | Extends BuildConfig with compact_banner. |
| src/project_config.rs | Adds compact_banner to jbundle.toml schema and test coverage for parsing. |
| src/pack/mod.rs | Extends PackOptions and forwards compact_banner into stub generation. |
| src/pack/stub.rs | Adds conditional compact-vs-ASCII banner behavior in the wrapper stub. |
| docs/reference/cli.md | Documents the new --compact-banner option. |
| docs/guide/configuration.md | Documents the new compact_banner configuration key. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
@cereda update to branch |
Contributor
|
@cereda Please merge |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented
--compact-bannerCLI flag as discussed in #39 (also available ascompact_bannerkey in the config file).When flag is present (or corresponding key set to
truein the config file),jbundleshould replaceby
in the application wrapper script (wording per author's suggestion).
Hope it works. Cheers! 😉