Merged
Conversation
openclaw tui runs an interactive terminal UI and wasn't recognized as a known tool, so users had to install and configure it manually. Registered openclaw across the full tool lifecycle: CLI listing, remote install via agent, devtools config/state, and project config. Uses `npm install -g openclaw` consistent with the other npm-based tools. Sources: - https://docs.openclaw.ai/help/faq - https://www.digitalocean.com/community/tutorials/how-to-run-openclaw Signed-off-by: Avelino <31996+avelino@users.noreply.github.com>
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Signed-off-by: Avelino <31996+avelino@users.noreply.github.com>
Comment on lines
57
to
66
| #[serde(default = "default_true")] | ||
| pub opencode: bool, | ||
|
|
||
| /// Install OpenClaw AI assistant (with TUI mode: openclaw tui) | ||
| #[serde(default = "default_true")] | ||
| pub openclaw: bool, | ||
|
|
||
| /// Install GitHub Copilot CLI | ||
| #[serde(default = "default_true")] | ||
| pub copilot: bool, |
There was a problem hiding this comment.
Bug: The openclaw field is missing from the cloud-init template. Due to #[serde(default = "default_true")] in DevToolsConfig, it will always be installed, ignoring user configuration.
Severity: CRITICAL
Suggested Fix
Add the openclaw field and other missing AI tool fields (e.g., cursor, cody, aider, gemini) to the devtools.json generation logic in the cloud-init template. Ensure their values are correctly populated based on the user's configuration.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: src/agent/devtools/types.rs#L57-L66
Potential issue: The `devtools.json` file generated by the cloud-init template is
missing the `openclaw` field, as well as fields for other AI tools like `cursor`,
`cody`, `aider`, and `gemini`. When the agent's `DevToolsConfig` struct is deserialized
from this JSON, the `#[serde(default = "default_true")]` attribute causes these missing
fields to default to `true`. This results in these tools always being installed on new
VMs, regardless of the user's configuration, even if they are explicitly set to false.
This overrides user intent and wastes installation time and resources.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openclaw tui runs an interactive terminal UI and wasn't recognized as a known tool, so users had to install and configure it manually.
Registered openclaw across the full tool lifecycle: CLI listing, remote install via agent, devtools config/state, and project config. Uses
npm install -g openclawconsistent with the other npm-based tools.Sources: