fix: resolve tag removal bug - tags can now be properly added/removed#32
Merged
brianorwhatever merged 1 commit intomainfrom Feb 7, 2026
Merged
fix: resolve tag removal bug - tags can now be properly added/removed#32brianorwhatever merged 1 commit intomainfrom
brianorwhatever merged 1 commit intomainfrom
Conversation
Bug: Tags couldn't be removed and appeared on every item. Root cause: ItemDetailsModal received stale item snapshots stored in React state. When tags were updated on the server, the modal still showed the old data because it was using a snapshot instead of the live query data. Fix: - Store only item IDs in state (editingItemId, selectedCalendarItemId) - Look up live items from the reactive items array using useMemo - This ensures tag changes are immediately reflected in the modal UI The modal now receives real-time updates from Convex queries, so tag additions/removals are properly reflected in the UI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fixed
Issue: "Can't remove tags and they seem to be on every item"
Root Cause
The ItemDetailsModal was receiving stale item snapshots stored in React state. When tags were updated on the server via mutations, the modal still showed the old
item.tagsdata because it was using a snapshot instead of live query data.Before (broken flow):
setEditingItem(item)stores a snapshotitem.tagsitemsarray from useQuery updates (reactive)editingItemin React state is still the old snapshotFix
editingItemandselectedCalendarItemstate fromDoc<"items"> | nulltoId<"items"> | nullitemsarray usinguseMemoAfter (fixed flow):
setEditingItemId(item._id)stores only the IDitemsarray from useQuery updateseditingItemuseMemo recalculates with live dataTesting