This repository was archived by the owner on Aug 7, 2018. It is now read-only.
Making the generate code more similar to the one generated with django v... #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o version 1.4. This fix #2 of upstream
Author
|
Ups, I think my editor convert automatically to unix style end of line. I just remove the import datetime (not used) and move lines 295 and 295 after the "values" clause. |
Owner
|
Thanks for the pull request, but I can't in good conscience accept it after you've retabbed it (I'm guessing you replaced tabs with spaces, or maybe \r\n with \n?). It's something I've wanted to do myself but I've refrained so it's easy to see the differences compared to upstream. [edit] I see you mention it as well. I'll make the changes myself manually; and close this PR once done, thanks. |
onysos
pushed a commit
to onysos/django-pyodbc
that referenced
this pull request
Dec 18, 2013
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix #2.