fix: include man pages in binary distribution archives#111
Merged
Conversation
The Homebrew formula expects man pages at buildpath/"man/*.1" but cargo-dist's binary tarballs only include the binary and basic docs by default. This caused the test-homebrew workflow to fail after v1.0.12 release because man pages weren't being installed. Adding `include = ["./man/"]` to dist-workspace.toml tells cargo-dist to include the pre-generated man pages in all binary archives. Fixes the missing man pages in Homebrew installations. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
avihut
force-pushed
the
fix/include-man-pages-in-dist
branch
from
65eab8f to
b1e107c
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
include = ["./man/"]to cargo-dist configuration to include pre-generated man pages in binary tarballsProblem
The test-homebrew workflow failed after v1.0.12 release because man pages were missing from the Homebrew installation.
Root cause: cargo-dist's binary tarballs only include the compiled binary and basic docs (README, LICENSE, CHANGELOG) by default. The Homebrew formula expected man pages at
buildpath/"man/*.1"but that directory didn't exist in the downloaded archive.Solution
The cargo-dist
includedirective specifies additional files/directories to bundle in distribution archives. Addinginclude = ["./man/"]ensures the pre-generated man pages are included in all binary tarballs.Verification
Locally verified with
cargo dist build --artifacts=local --target=aarch64-apple-darwin:Test plan
🤖 Generated with Claude Code