fix: install man pages before pkgshare.install in Homebrew formula#113
Merged
fix: install man pages before pkgshare.install in Homebrew formula#113
Conversation
The previous awk command inserted man page installation AFTER pkgshare.install, but leftover_contents included the man directory, which got moved to pkgshare before man1.install could access it. Fixed by: 1. Excluding "man" from leftover_contents so it doesn't get moved 2. Installing man pages BEFORE pkgshare.install runs This ensures man pages are properly installed and discoverable via `man`. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
9378b8b to
fc0798e
Compare
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
After v1.0.13 was released with man pages included in the binary tarballs, the test-homebrew workflow still failed because man pages weren't being installed properly.
Root cause: The awk command in release.yml inserted
man1.install Dir[buildpath/"man/*.1"]AFTERpkgshare.install(*leftover_contents). Butleftover_contentsincluded themandirectory, which got moved to pkgshare beforeman1.installcould access it.Solution
Updated the awk command to:
leftover_contentsso it doesn't get moved to pkgsharepkgshare.installrunsBefore (broken):
After (fixed):
Test plan
🤖 Generated with Claude Code