Skip to content

fix: add retry logic for release PR detection in man page update#117

Merged
avihut merged 1 commit intomasterfrom
fix/release-plz-race-condition
Jan 28, 2026
Merged

fix: add retry logic for release PR detection in man page update#117
avihut merged 1 commit intomasterfrom
fix/release-plz-race-condition

Conversation

@avihut
Copy link
Owner

@avihut avihut commented Jan 28, 2026

Summary

Adds retry logic to the man page update step in the release-plz workflow to handle GitHub API propagation delays.

Problem

In PR #115, we added a step to automatically regenerate man pages when release-plz creates a release PR. However, the step runs immediately after the PR is created, before GitHub has fully propagated the labels. This caused the gh pr list --label release command to return empty.

This resulted in PR #116 (v1.0.15) being created without the man page regeneration, requiring manual intervention.

Solution

  • Add initial 5 second delay to let GitHub propagate
  • Add retry logic (3 attempts with 5 second delays)
  • Better logging for debugging

Test plan

  • CI passes
  • Next release PR should have man pages automatically regenerated

🤖 Generated with Claude Code

The previous workflow had a race condition where the man page update
step would run immediately after release-plz created the PR, but
before GitHub had fully propagated the PR labels.

This fix adds:
- Initial 5 second delay
- Retry logic (3 attempts with 5 second delays)
- Better logging for debugging

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@avihut avihut merged commit 2c922a1 into master Jan 28, 2026
5 checks passed
@avihut avihut deleted the fix/release-plz-race-condition branch January 28, 2026 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant