fix: show error message and suggestions for unknown subcommands#121
Merged
fix: show error message and suggestions for unknown subcommands#121
Conversation
When a user types an unknown subcommand (e.g., `daft foo` or `git daft foo`), the binary now prints a clear error message to stderr and exits with code 1, instead of silently showing the full help text and exiting with code 0. Includes Levenshtein distance-based "did you mean?" suggestions that mirror git's own error format. Fixes #110 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The unknown subcommand handler was catching --help and -h flags for both `daft` and `git-daft`, treating them as unknown commands. Add explicit match arms for these flags to route to docs::run() instead. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
daft foo,git daft foo) now print a clear error to stderr and exit with code 1, instead of silently showing help and exiting with code 0daft steupsuggestssetup)daftandgit-daftwith no arguments continue to show help and exit with code 0Test plan
cargo fmt -- --checkpassescargo clippy -- -D warningspassescargo test --lib— 135 unit tests pass (15 new tests for suggest module)just test-integration-unknown-command— 6 integration tests passdaft nonexistent,daft steup,daft(no args),git-daft foo,git-daft(no args)Fixes #110
🤖 Generated with Claude Code