feat(doctor): improve output format, fix bugs, and add --dry-run#222
Merged
feat(doctor): improve output format, fix bugs, and add --dry-run#222
Conversation
Redesign daft doctor with Flutter-doctor-inspired output where every line is self-explanatory. Key changes: - Fix bare repo misdetection: read git config instead of rev-parse --is-bare-repository (which returns false inside worktrees) - Fix worktree counting: skip bare repo entry in porcelain output - Add git-worktree-branch-delete to expected symlinks (now 11) - Add shortcut symlink checks (detects partially-installed styles) - Add shell wrapper check (verifies auto-cd is active) - Add hooks config detection via daft.yml (not just .daft/hooks/) - Non-bare repo is now a pass, not a warning - Replace fixable bool with fix closure (self-contained checks) - New output format: [symbol] name (message) for pass, dash for issues - Hide skipped checks by default (shown with -v) - Summary shows issue names: "1 warning (Shortcuts)" Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
daft doctoroutput to a Flutter-doctor-inspired format with[✓]/[!]/[✗]/[−]status symbolsgit-worktree-branch-deleteto expected symlinks (now 11/11)daft.ymlhook detection to the Hooks categoryCheckResult(eliminates string-matching dispatch)--dry-runflag to preview fixes without applying them (daft doctor --fix --dry-run)Test plan
mise run clippypasses with zero warningsmise run test-unitall 333 tests passdaft doctorinside a bare-repo worktree shows correct layout/countsdaft doctoroutside any git repo shows only Installation sectiondaft doctor -vshows skipped checksdaft doctor -qshows only warnings/failuresdaft doctor --fix --dry-runlists fixable issues without applying themdaft doctor --dry-run(without--fix) shows clap error🤖 Generated with Claude Code