Skip to content

fix: render hook job output after heading, not before#223

Merged
avihut merged 2 commits intomasterfrom
hook-prints-fix
Feb 18, 2026
Merged

fix: render hook job output after heading, not before#223
avihut merged 2 commits intomasterfrom
hook-prints-fix

Conversation

@avihut
Copy link
Owner

@avihut avihut commented Feb 18, 2026

Summary

  • Fix hook progress rendering so job output appears after the job heading, not before it
  • Simplify integration test matrix by removing unnecessary git_config env var for the gitoxide entry

Test plan

  • Unit tests pass
  • CI integration tests pass for both default and gitoxide matrix entries
  • Hook output renders correctly with job heading appearing before output lines

🤖 Generated with Claude Code

avihut and others added 2 commits February 18, 2026 08:09
Clear all progress bars (including spinner) from indicatif's draw area
before printing output. Previously, finish_with_message() created
"zombie" bars that flushed on MultiProgress drop after the summary,
and mp.println() inserted output above the still-active spinner.

Now each job's output renders as: heading, output lines, empty line.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@avihut avihut added this to the v1.1.0 milestone Feb 18, 2026
@avihut avihut added the fix Bug fix label Feb 18, 2026
@avihut avihut self-assigned this Feb 18, 2026
@avihut avihut added the bug Something isn't working label Feb 18, 2026
@avihut avihut merged commit 9266921 into master Feb 18, 2026
6 checks passed
@avihut avihut deleted the hook-prints-fix branch February 18, 2026 06:14
This was referenced Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant