fix: grow hook output window dynamically instead of pre-allocating blank lines#237
Merged
fix: grow hook output window dynamically instead of pre-allocating blank lines#237
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…lank lines Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProgressBarslots instart_job— no blank lines appear before any output arrivesupdate_job_output: window starts at 0 lines and grows one slot per output line until the configured maximum (default 6), then rollsself.jobsandself.mpTest Plan
test_dynamic_window_starts_empty— tail count is 0 afterstart_jobwith no outputtest_dynamic_window_grows_with_output— count increments 1 per line up to maxtest_dynamic_window_caps_at_max— count stays at max after cap; buffer holds all linestest_dynamic_window_zero_output_no_separator— silent jobs finish cleanly with no bars allocatedFixes #236
🤖 Generated with Claude Code